Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2558173004:
DevTools: [Search] fix search results text (Closed)
|
Created:
4 years ago by lushnikov Modified:
4 years ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: [Search] fix search results text
Since our search is looking for found lines, not matches. This
patch changes wording about search results to make this explicit.
As a drive by, this patch starts using proper singular/plural
nouns.
BUG=585406
R=dgozman
Committed: https://crrev.com/238786040920c8b4992f679ea454efbf740881d6
Cr-Commit-Position: refs/heads/master@{#437485}
Patch Set 1 #Patch Set 2 : nit #Messages
Total messages: 20 (13 generated)
Description was changed from ========== DevTools: search should state amount of found lines, not matches Since our search is looking for found lines, not matches, we should state this explicitly. BUG=585406 R=dgozman ========== to ========== DevTools: search should state amount of found lines, not matches Since our search is looking for found lines, not matches, we should state this explicitly. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ==========
please, take a look
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
Description was changed from ========== DevTools: search should state amount of found lines, not matches Since our search is looking for found lines, not matches, we should state this explicitly. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ========== to ========== DevTools: fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ==========
Description was changed from ========== DevTools: fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ========== to ========== DevTools: [Search] fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ==========
lgtm
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481260477657200,
"parent_rev": "e3335ec7e78c0991aceb2074e1349952df8d811e", "commit_rev":
"278e709a38b3f7344ec56675890f71b669ded515"}
Message was sent while issue was closed.
Description was changed from ========== DevTools: [Search] fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ========== to ========== DevTools: [Search] fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== DevTools: [Search] fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman ========== to ========== DevTools: [Search] fix search results text Since our search is looking for found lines, not matches. This patch changes wording about search results to make this explicit. As a drive by, this patch starts using proper singular/plural nouns. BUG=585406 R=dgozman Committed: https://crrev.com/238786040920c8b4992f679ea454efbf740881d6 Cr-Commit-Position: refs/heads/master@{#437485} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/238786040920c8b4992f679ea454efbf740881d6 Cr-Commit-Position: refs/heads/master@{#437485} |
