Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2558133002: Enable more async code on node (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable more async code on node This is primarily for easier testing/repro on node which has "global", but not "self". R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/dd16c377fbde1619ce15ec7a637831b87d12aad0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -133 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 14 chunks +27 lines, -26 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 14 chunks +27 lines, -26 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 14 chunks +27 lines, -26 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 14 chunks +27 lines, -26 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/async_patch.dart View 6 chunks +10 lines, -9 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/isolate_helper.dart View 9 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years ago (2016-12-07 17:37:11 UTC) #3
Jennifer Messerly
LGTM!
4 years ago (2016-12-07 18:37:41 UTC) #4
vsm
4 years ago (2016-12-07 18:52:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd16c377fbde1619ce15ec7a637831b87d12aad0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698