Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 255813003: ServiceWorker: Queue worker state changes until Blink is ready for them (Closed)

Created:
6 years, 8 months ago by falken
Modified:
6 years, 7 months ago
Reviewers:
kinuko, michaeln
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Queue worker state changes until Blink is ready for them Chromium-side part of the following: https://codereview.chromium.org/247263010/ https://codereview.chromium.org/256723002/ BUG=365252 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266544

Patch Set 1 #

Patch Set 2 : include style #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M content/child/service_worker/service_worker_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/web_service_worker_impl.h View 1 3 chunks +11 lines, -1 line 2 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 2 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
falken
6 years, 8 months ago (2014-04-25 07:49:50 UTC) #1
kinuko
lgtm https://codereview.chromium.org/255813003/diff/20001/content/child/service_worker/web_service_worker_impl.h File content/child/service_worker/web_service_worker_impl.h (right): https://codereview.chromium.org/255813003/diff/20001/content/child/service_worker/web_service_worker_impl.h#newcode48 content/child/service_worker/web_service_worker_impl.h:48: void ChangeState(blink::WebServiceWorkerState new_state); nit: CommitStateChange() maybe, to clearly ...
6 years, 8 months ago (2014-04-25 08:07:34 UTC) #2
falken
https://codereview.chromium.org/255813003/diff/20001/content/child/service_worker/web_service_worker_impl.h File content/child/service_worker/web_service_worker_impl.h (right): https://codereview.chromium.org/255813003/diff/20001/content/child/service_worker/web_service_worker_impl.h#newcode48 content/child/service_worker/web_service_worker_impl.h:48: void ChangeState(blink::WebServiceWorkerState new_state); On 2014/04/25 08:07:34, kinuko wrote: > ...
6 years, 8 months ago (2014-04-27 03:31:16 UTC) #3
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-04-28 09:09:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/255813003/20001
6 years, 7 months ago (2014-04-28 09:14:26 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 09:17:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_gn_rel
6 years, 7 months ago (2014-04-28 09:17:06 UTC) #7
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-04-28 09:21:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/255813003/20001
6 years, 7 months ago (2014-04-28 09:22:06 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 13:50:30 UTC) #10
Message was sent while issue was closed. 
Change committed as 266544

Powered by Google App Engine
This is Rietveld 408576698