Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html

Issue 2558113002: Drop-down closes via tap/touch again. (Closed)
Patch Set: Always reset the m_lastHiddenPopUp at the end of a GestureTap Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
diff --git a/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
index ea2f3651f5fedc0309157e81735cfa8c65f93052..09d3f6d94591dd8de6584247d22a80b7d6bc2e11 100644
--- a/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
+++ b/third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations.html
@@ -155,13 +155,35 @@ function test3() {
openPicker(menuElement, function () {
eventSender.gestureTapDown(300, 300);
shouldBeNull('window.internals.pagePopupWindow');
- finishJSTest();
+ test4();
}, function () {
testFailed('picker didn\'t open')
finishJSTest();
});
}
+function test4() {
+ debug("==> Test popup doesn't reopen immediately after closing");
+ eventSender.clearTouchPoints();
+ shouldBeNull('window.internals.pagePopupWindow');
+
+ // Open the popup with a GestureTap.
+ var position = elementCenterPosition(menuElement);
+ eventSender.gestureTapDown(position[0], position[1]);
+ shouldBeNull('window.internals.pagePopupWindow');
+ eventSender.gestureTap(position[0], position[1]);
+ shouldNotBe('window.internals.pagePopupWindow', 'null');
+
+ // GestureTapDown on an open popup closes it.
+ eventSender.gestureTapDown(position[0], position[1]);
+ shouldBeNull('window.internals.pagePopupWindow');
+
+ // The next GestureTap on the recently closed popup shouldn't open it.
+ eventSender.gestureTap(position[0], position[1]);
+ shouldBeNull('window.internals.pagePopupWindow');
+
+ finishJSTest();
+}
</script>
</body>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-touch-operations-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698