No Goodies for Supervised Users

No Goodies for Supervised Users

BUG=669292
TEST=On new device, create and log in with a supervised user before
device owner has opened a browser.  Supervised user shouldn't see
Goodies tab.  Now log in with device owner, they should see Goodies.

Committed: https://crrev.com/332f31fde7c64c505b63649dc92fb30ad1f0646a
Cr-Commit-Position: refs/heads/master@{#437148}

[Greg Levin, 2016-12-07 16:50:10]

glevin@chromium.org changed reviewers:
+ achuith@chromium.org

[Greg Levin, 2016-12-07 16:50:10]

Please have a look!

[Greg Levin, 2016-12-07 16:50:15]

The CQ bit was checked by glevin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 16:50:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 17:27:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 17:27:50]

Dry run: This issue passed the CQ dry run.

[achuithb, 2016-12-07 18:38:08]

Is there an easy way to browser test this?

[Greg Levin, 2016-12-08 00:12:28]

On 2016/12/07 18:38:08, achuithb wrote:
> Is there an easy way to browser test this?

I looked into it briefly, and it would need a separate test and class to
generate the supervised login.  I don't think it would be too hard, but I wasn't
sure it was worth it for such a simple edge case.  Let me know if you want me to
give it a shot.

[achuithb, 2016-12-08 00:49:38]

On 2016/12/08 00:12:28, Greg Levin wrote:
> On 2016/12/07 18:38:08, achuithb wrote:
> > Is there an easy way to browser test this?
> 
> I looked into it briefly, and it would need a separate test and class to
> generate the supervised login.  I don't think it would be too hard, but I
wasn't
> sure it was worth it for such a simple edge case.  Let me know if you want me
to
> give it a shot.

All right, let's not worry about it. The original request was more like a P2/P3.
It's not fatal if this regresses.

LGTM.

[Greg Levin, 2016-12-08 01:55:38]

The CQ bit was checked by glevin@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:56:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 02:17:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481162138433550, "parent_rev":
"f695d9461b91770bada7bed8605f6e88b127ba99", "commit_rev":
"783847d8c0e46436c0a3487166504dcd2a3c8f72"}

[commit-bot: I haz the power, 2016-12-08 02:18:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-08 02:22:43]

Description was changed from

==========
No Goodies for Supervised Users

BUG=669292
TEST=On new device, create and log in with a supervised user before
device owner has opened a browser.  Supervised user shouldn't see
Goodies tab.  Now log in with device owner, they should see Goodies.
==========

to

==========
No Goodies for Supervised Users

BUG=669292
TEST=On new device, create and log in with a supervised user before
device owner has opened a browser.  Supervised user shouldn't see
Goodies tab.  Now log in with device owner, they should see Goodies.

Committed: https://crrev.com/332f31fde7c64c505b63649dc92fb30ad1f0646a
Cr-Commit-Position: refs/heads/master@{#437148}
==========

[commit-bot: I haz the power, 2016-12-08 02:22:44]

Patchset 1 (id:??) landed as
https://crrev.com/332f31fde7c64c505b63649dc92fb30ad1f0646a
Cr-Commit-Position: refs/heads/master@{#437148}