components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc - Issue 2558043007: Fix free memory calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc

Issue 2558043007: Fix free memory calculation. (Closed)

Patch Set: Fix integer overflow in unittest. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/memory_pressure/direct_memory_pressure_calculator_win.cc ('k') | content/browser/memory/memory_monitor_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc

diff --git a/components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc b/components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc

index c7c48e6f1998122b71bcb6dbc4d959f3bc601567..a8f0ec5aafceba34d08fdb66286d74b15037d462 100644

--- a/components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc

+++ b/components/memory_pressure/direct_memory_pressure_calculator_win_unittest.cc

@@ -59,8 +59,8 @@ class TestDirectMemoryPressureCalculator

// |total| is set in the constructor and not modified.

// Set the amount of free memory.

- mem_info_.free = phys_left_mb * kKBperMB;

- DCHECK_LT(mem_info_.free, mem_info_.total);

+ mem_info_.avail_phys = phys_left_mb * kKBperMB;

+ DCHECK_LT(mem_info_.avail_phys, mem_info_.total);

}

void SetNone() { SetMemoryFree(moderate_threshold_mb() + 1); }