Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 255803003: Linux perf support update. (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 5 months ago
Reviewers:
Yang, danno
CC:
v8-dev
Visibility:
Public.

Description

Linux perf tool support update + refactoring. This adds timestamps to allow profiling with code space reuse. Also a couple of updates to reflect the changes in the JIT perf interface + a move of the perf-related stuff into separate files. Unfortunately, the change only works with the latest patch to the perf tool from a Linux perf tool contributor (Stephane Eranian). BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22098

Patch Set 1 #

Patch Set 2 : Rebase, update to the new perf tool interface #

Patch Set 3 : Header cleanup #

Patch Set 4 : Fix non-linux build #

Patch Set 5 : Remove unused macro #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -173 lines) Patch
M src/base/platform/platform.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/base/platform/platform-posix.cc View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M src/base/platform/platform-win32.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 5 1 chunk +0 lines, -6 lines 0 comments Download
M src/log.cc View 1 2 3 4 5 2 chunks +1 line, -166 lines 0 comments Download
A src/perf-jit.h View 1 2 3 1 chunk +129 lines, -0 lines 0 comments Download
A src/perf-jit.cc View 1 2 3 4 5 1 chunk +169 lines, -0 lines 0 comments Download
A src/third_party/kernel/tools/perf/util/jitdump.h View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jarin
Could you have a look?
6 years, 5 months ago (2014-06-30 12:49:20 UTC) #1
Yang
On 2014/06/30 12:49:20, jarin wrote: > Could you have a look? lgtm.
6 years, 5 months ago (2014-06-30 12:59:01 UTC) #2
Jarin
Committed patchset #6 manually as r22098 (presubmit successful).
6 years, 5 months ago (2014-06-30 14:36:43 UTC) #3
weiliang.lin2
Great support! Could you please share where to get the the latest patch to the ...
6 years, 5 months ago (2014-07-04 02:56:01 UTC) #4
Jarin
On 2014/07/04 02:56:01, weiliang.lin2 wrote: > Great support! > Could you please share where to ...
6 years, 5 months ago (2014-07-08 08:03:15 UTC) #5
Weiliang
6 years, 5 months ago (2014-07-08 09:22:21 UTC) #6
Message was sent while issue was closed.
On 2014/07/08 08:03:15, jarin wrote:
> On 2014/07/04 02:56:01, weiliang.lin2 wrote:
> > Great support!
> > Could you please share where to get the the latest patch to the perf tool
from
> a
> > Linux perf tool contributor (Stephane Eranian)?
> > 
> > Thanks
> > -Weiliang
> 
> Stephane says the patch is only for internal testing, but he is hoping to
> release the patch publicly by the end of the month.

Thanks for the information

Powered by Google App Engine
This is Rietveld 408576698