Move handling of regular static use from ResolutionEnqueuer to ResolutionWorldBuilderImpl

Move handling of regular static use from ResolutionEnqueuer to ResolutionWorldBuilderImpl

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/015ff751430bd7c2fc827a65fce89a125daa5715

[Johnni Winther, 2016-12-07 10:28:03]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Johnni Winther, 2016-12-07 10:28:04]

https://codereview.chromium.org/2558013002/diff/20001/pkg/compiler/lib/src/de...
File pkg/compiler/lib/src/deferred_load.dart (right):

https://codereview.chromium.org/2558013002/diff/20001/pkg/compiler/lib/src/de...
pkg/compiler/lib/src/deferred_load.dart:431:
cls.implementation.forEachMember(addLiveInstanceMember);
Avoid calling [ResolutionEnqueuer.hasBeenProcessed] with patch elements.

https://codereview.chromium.org/2558013002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/diagnose_ambiguous_test.dart (right):

https://codereview.chromium.org/2558013002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/diagnose_ambiguous_test.dart:28:
"memory:library.dart:41:47:'hest' is defined here.:info",
Slight change in resolution order caused element nodes to be parsed before error
reporting, causing the span to be based on the function signature and not the
name, i.e. from `hest` to `hest()`.

[Harry Terkelsen, 2016-12-07 21:02:00]

lgtm

https://codereview.chromium.org/2558013002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2558013002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:697: void
registerStaticUse(StaticUse staticUse, MemberUsed memberUsed) {
Maybe rename this typedef to 'MemberUsedCallback' or something? It's not obvious
that it's a callback, it looks like it's a reference to the member which is
used. It's also very close to 'MemberUse'

[Johnni Winther, 2016-12-08 08:56:12]

https://codereview.chromium.org/2558013002/diff/20001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2558013002/diff/20001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/world_builder.dart:697: void
registerStaticUse(StaticUse staticUse, MemberUsed memberUsed) {
On 2016/12/07 21:02:00, Harry Terkelsen wrote:
> Maybe rename this typedef to 'MemberUsedCallback' or something? It's not
obvious
> that it's a callback, it looks like it's a reference to the member which is
> used. It's also very close to 'MemberUse'

Done.

[Johnni Winther, 2016-12-08 09:01:31]

Description was changed from

==========
Move handling of regular static use from ResolutionEnqueuer to
ResolutionWorldBuilderImpl
==========

to

==========
Move handling of regular static use from ResolutionEnqueuer to
ResolutionWorldBuilderImpl

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/015ff751430bd7c2fc827a65fce89a125daa5715
==========

[Johnni Winther, 2016-12-08 09:01:32]

Committed patchset #3 (id:40001) manually as
015ff751430bd7c2fc827a65fce89a125daa5715 (presubmit successful).