Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2557963003: bluetooth: Implement acceptAllDevices (Closed)

Created:
4 years ago by ortuno
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

bluetooth: Implement acceptAllDevices When acceptAllDevices is true the chooser will show all devices in range. BUG=654918 Review-Url: https://codereview.chromium.org/2510323002 Cr-Commit-Position: refs/heads/master@{#436209} Committed: https://chromium.googlesource.com/chromium/src/+/e893975dc2937a712f5ffcc14f2892705a286cdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -99 lines) Patch
M content/browser/bad_message.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/bluetooth/bluetooth_allowed_devices_map.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc View 10 chunks +22 lines, -12 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 6 chunks +55 lines, -27 lines 0 comments Download
M content/browser/bluetooth/bluetooth_metrics.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M content/renderer/bluetooth/bluetooth_type_converters.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 chunk +12 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 2 chunks +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-empty-name.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-name.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-no-name.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/device-with-uuids.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-missing.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/acceptAllDevices/optional-services-present.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/filters-xor-acceptAllDevices.html View 1 chunk +28 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/no-filters-member.html View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 3 chunks +30 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/RequestDeviceOptions.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ortuno
4 years ago (2016-12-08 01:02:19 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e893975dc2937a712f5ffcc14f2892705a286cdf (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698