Issue 2557963002: Convert WPT export usage of httplib2 to urllib2

Issue 2557963002: Convert WPT export usage of httplib2 to urllib2 (Closed)

Created:
4 years ago by jeffcarp

Modified:
4 years ago

Reviewers:
tkent, Dirk Pranke, dglazkov, qyearsley

CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Convert WPT export usage of httplib2 to urllib2 BUG=670987 Committed: https://crrev.com/330c5f636e80344d7a9c4ef6ade63e1eb297ec7d Cr-Commit-Position: refs/heads/master@{#436861}

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -37 lines)			Patch
M	third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py	View	4 chunks	+19 lines, -35 lines	0 comments	Download
M	third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (5 generated)

Dirk Pranke

lgtm. Probably want tkent@ to review it, too, since he wrote the code originally.

4 years ago (2016-12-07 02:15:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557963002/1

4 years ago (2016-12-07 02:29:40 UTC) #7

commit-bot: I haz the power

4 years ago (2016-12-07 04:39:32 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/330c5f636e80344d7a9c4ef6ade63e1eb297ec7d
Cr-Commit-Position: refs/heads/master@{#436861}