Toast notifying the user that we copied to clipboard.

Toast notifying the user that we copied to clipboard.

BUG=367021

[kth81.kim, 2014-04-25 12:29:20]

PTAL

[jdduke (slow), 2014-04-25 14:42:47]

On 2014/04/25 12:29:20, kth81.kim wrote:
> PTAL

Is this toasting behavior consistent with native Android apps?

[kth81.kim1, 2014-04-25 14:53:48]

On 2014/04/25 14:42:47, jdduke wrote:
> On 2014/04/25 12:29:20, kth81.kim wrote:
> > PTAL
> 
> Is this toasting behavior consistent with native Android apps?

Yes. this toasting behavior is equal to native Android apps.

[jdduke (slow), 2014-04-25 15:30:55]

On 2014/04/25 14:53:48, kth81.kim1 wrote:
> On 2014/04/25 14:42:47, jdduke wrote:
> > On 2014/04/25 12:29:20, kth81.kim wrote:
> > > PTAL
> > 
> > Is this toasting behavior consistent with native Android apps?
> 
> Yes. this toasting behavior is equal to native Android apps.

Thanks, I'll defer to tedchoc@ here as this is more of a UX change.

[Ted C, 2014-04-25 19:42:52]

On 2014/04/25 15:30:55, jdduke wrote:
> On 2014/04/25 14:53:48, kth81.kim1 wrote:
> > On 2014/04/25 14:42:47, jdduke wrote:
> > > On 2014/04/25 12:29:20, kth81.kim wrote:
> > > > PTAL
> > > 
> > > Is this toasting behavior consistent with native Android apps?
> > 
> > Yes. this toasting behavior is equal to native Android apps.
> 
> Thanks, I'll defer to tedchoc@ here as this is more of a UX change.

The toast is not standard across the platform.  According to the bug,
it might already happen on certain devices, so this might end up causing
a double toast.

I'll inquire with the UX team here, but I'm tempted to say we should not
be doing this.

[kth81.kim, 2014-04-28 09:45:02]

On 2014/04/25 19:42:52, Ted C wrote:
> On 2014/04/25 15:30:55, jdduke wrote:
> > On 2014/04/25 14:53:48, kth81.kim1 wrote:
> > > On 2014/04/25 14:42:47, jdduke wrote:
> > > > On 2014/04/25 12:29:20, kth81.kim wrote:
> > > > > PTAL
> > > > 
> > > > Is this toasting behavior consistent with native Android apps?
> > > 
> > > Yes. this toasting behavior is equal to native Android apps.
> > 
> > Thanks, I'll defer to tedchoc@ here as this is more of a UX change.
> 
> The toast is not standard across the platform.  According to the bug,
> it might already happen on certain devices, so this might end up causing
> a double toast.
> 
> I'll inquire with the UX team here, but I'm tempted to say we should not
> be doing this.

chrome browser in Android doesn't show any noti for cut/copy, but when user
longpress on urlbar, user can see toast message for cup/copy.
If you are worrying about double toast message, I will add android checking
flag. is it ok?

[Ted C, 2014-04-29 00:53:46]

On 2014/04/28 09:45:02, kth81.kim wrote:
> On 2014/04/25 19:42:52, Ted C wrote:
> > On 2014/04/25 15:30:55, jdduke wrote:
> > > On 2014/04/25 14:53:48, kth81.kim1 wrote:
> > > > On 2014/04/25 14:42:47, jdduke wrote:
> > > > > On 2014/04/25 12:29:20, kth81.kim wrote:
> > > > > > PTAL
> > > > > 
> > > > > Is this toasting behavior consistent with native Android apps?
> > > > 
> > > > Yes. this toasting behavior is equal to native Android apps.
> > > 
> > > Thanks, I'll defer to tedchoc@ here as this is more of a UX change.
> > 
> > The toast is not standard across the platform.  According to the bug,
> > it might already happen on certain devices, so this might end up causing
> > a double toast.
> > 
> > I'll inquire with the UX team here, but I'm tempted to say we should not
> > be doing this.
> 
> chrome browser in Android doesn't show any noti for cut/copy, but when user
> longpress on urlbar, user can see toast message for cup/copy.
> If you are worrying about double toast message, I will add android checking
> flag. is it ok?

Let me inquire with our UI designers first.  The normal android platform does
not show a toast when copying text.  On Samsung device, it does when you do
it from a TextView.  I want to confirm with the designers whether we should
be inconsistent with the platform or with the behavior on certain OEM's phones.

[kth81.kim1, 2014-05-09 04:42:01]

On 2014/04/29 00:53:46, Ted C wrote:
> On 2014/04/28 09:45:02, kth81.kim wrote:
> > On 2014/04/25 19:42:52, Ted C wrote:
> > > On 2014/04/25 15:30:55, jdduke wrote:
> > > > On 2014/04/25 14:53:48, kth81.kim1 wrote:
> > > > > On 2014/04/25 14:42:47, jdduke wrote:
> > > > > > On 2014/04/25 12:29:20, kth81.kim wrote:
> > > > > > > PTAL
> > > > > > 
> > > > > > Is this toasting behavior consistent with native Android apps?
> > > > > 
> > > > > Yes. this toasting behavior is equal to native Android apps.
> > > > 
> > > > Thanks, I'll defer to tedchoc@ here as this is more of a UX change.
> > > 
> > > The toast is not standard across the platform.  According to the bug,
> > > it might already happen on certain devices, so this might end up causing
> > > a double toast.
> > > 
> > > I'll inquire with the UX team here, but I'm tempted to say we should not
> > > be doing this.
> > 
> > chrome browser in Android doesn't show any noti for cut/copy, but when user
> > longpress on urlbar, user can see toast message for cup/copy.
> > If you are worrying about double toast message, I will add android checking
> > flag. is it ok?
> 
> Let me inquire with our UI designers first.  The normal android platform does
> not show a toast when copying text.  On Samsung device, it does when you do
> it from a TextView.  I want to confirm with the designers whether we should
> be inconsistent with the platform or with the behavior on certain OEM's
phones.

Are you still checking with UI designers?
Please let me know the current status.

[kth81.kim1, 2014-05-09 04:46:18]

The CQ bit was checked by kth81.kim@samsung.com

[kth81.kim1, 2014-05-09 04:46:18]

The CQ bit was unchecked by kth81.kim@samsung.com

[kbalazs, 2014-06-18 21:33:11]

Any progress here?

[Ted C, 2014-06-20 01:25:48]

On 2014/06/18 21:33:11, kbalazs wrote:
> Any progress here?

Sorry for the delay, but at this point the UI designers prefer to keep
consistent with the AOSP platform.

Is this something that could be done inside the ClipboardManager itself?

[jdduke (slow), 2014-11-13 01:33:19]

jdduke@chromium.org changed reviewers:
- jdduke@chromium.org

[Ted C, 2014-12-02 21:59:55]

tedchoc@chromium.org changed reviewers:
- tedchoc@chromium.org