Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2557923004: [modules] Remove outdated TODO in module namespace objects test (Closed)

Created:
4 years ago by adamk
Modified:
4 years ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Remove outdated TODO in module namespace objects test As of https://github.com/tc39/ecma262/commit/13906140a, the spec now returns true when [[SetPrototypeOf]] is invoked with null on a module namespace object. R=neis@chromium.org BUG=v8:1569 Committed: https://crrev.com/6505e022662d368e09e28148d24ab1d0a4887aa4 Cr-Commit-Position: refs/heads/master@{#41575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/mjsunit/modules-namespace1.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
4 years ago (2016-12-08 01:40:20 UTC) #1
neis
lgtm, thanks. Shall I remove @@iterator now?
4 years ago (2016-12-08 08:18:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557923004/1
4 years ago (2016-12-08 08:19:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 08:43:36 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6505e022662d368e09e28148d24ab1d0a4887aa4 Cr-Commit-Position: refs/heads/master@{#41575}
4 years ago (2016-12-08 08:43:58 UTC) #8
adamk
4 years ago (2016-12-08 16:48:49 UTC) #9
Message was sent while issue was closed.
On 2016/12/08 08:18:59, neis wrote:
> lgtm, thanks.
> 
> Shall I remove @@iterator now?

Feel free to prepare a CL, but we should wait till the PR is merged into the
spec before landing I'd say.

Powered by Google App Engine
This is Rietveld 408576698