Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2557913002: Remove begin_frame_source argument from VulkanBrowserCompositorOutputSurface ctor (Closed)

Created:
4 years ago by stanisc
Modified:
4 years ago
Reviewers:
danakj
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove begin_frame_source argument from VulkanBrowserCompositorOutputSurface ctor This removes an unneeded begin_frame_source from VulkanBrowserCompositorOutputSurface ctor. I've overlooked this in my previous change (https://codereview.chromium.org/2511273002/). The code wouldn't actually compile with the argument but I guess this class isn't built by either local build or trybots - that's why this has been overlooked. BUG=467617 Committed: https://crrev.com/90f047410034268ef03377f12408395e10fc1140 Cr-Commit-Position: refs/heads/master@{#436847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M content/browser/compositor/vulkan_browser_compositor_output_surface.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/vulkan_browser_compositor_output_surface.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
stanisc
Please review this trivial change.
4 years ago (2016-12-06 23:57:46 UTC) #8
danakj
LGTM
4 years ago (2016-12-07 01:11:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557913002/1
4 years ago (2016-12-07 02:37:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 02:45:46 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-07 02:48:52 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90f047410034268ef03377f12408395e10fc1140
Cr-Commit-Position: refs/heads/master@{#436847}

Powered by Google App Engine
This is Rietveld 408576698