Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2557903002: Revert "Suppress a use-after-free report in blink::RemoteFrame::detach()." (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
Reviewers:
nasko
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Suppress a use-after-free report in blink::RemoteFrame::detach()." This reverts commit f54c1207ebe045798603f6484ad1f59aecad061c. This is a speculative revert - the original problem doesn't seem to repro anymore (per https://crbug.com/432070#c17) so let's try to remove the (hopefully) no longer needed test suppression. BUG=432070 Committed: https://crrev.com/9e11ad5750fb228b83db25fcd90f77488659d750 Cr-Commit-Position: refs/heads/master@{#436765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Łukasz Anforowicz
nasko@, can you PTAL?
4 years ago (2016-12-06 21:58:31 UTC) #3
nasko
LGTM, assuming builder come out green.
4 years ago (2016-12-06 22:21:12 UTC) #5
Łukasz Anforowicz
On 2016/12/06 22:21:12, nasko (very slow til Dec 13th) wrote: > LGTM, assuming builder come ...
4 years ago (2016-12-06 22:28:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557903002/1
4 years ago (2016-12-06 22:29:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 22:53:39 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 22:56:58 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e11ad5750fb228b83db25fcd90f77488659d750
Cr-Commit-Position: refs/heads/master@{#436765}

Powered by Google App Engine
This is Rietveld 408576698