cc: Unregister FrameSink hierarchy on CompositorFrameSinkSupport destruction

cc: Unregister FrameSink hierarchy on CompositorFrameSinkSupport destruction

A CompositorFrameSinkSupport may be destroyed during test tear down without
Unregistering all BeginFrame children. This causes a DCHECK to fail in
SurfaceManager. With this change, CompositorFrameSinkSupport keeps a set
of all child FrameSinkIds, and Unregisters the FrameSinks at destruction if
any remain.

BUG=666481
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/15ee57778085a2abef4a6548cd79c28daa16e3c3
Cr-Commit-Position: refs/heads/master@{#436735}

[Fady Samuel, 2016-12-06 19:51:33]

Description was changed from

==========
cc: Unregister FrameSink hierarchy on CompositorFrameSinkSupport destruction

A CompositorFrameSinkSupport may be destroyed during test tear down without
Unregistering all BeginFrame children. This causes a DCHECK to fail in
SurfaceManager. With this change, CompositorFrameSinkSupport keeps a set
of all child FrameSinkIds, and Unregisters the FrameSinks at destruction if
any remain.

BUG=666481
==========

to

==========
cc: Unregister FrameSink hierarchy on CompositorFrameSinkSupport destruction

A CompositorFrameSinkSupport may be destroyed during test tear down without
Unregistering all BeginFrame children. This causes a DCHECK to fail in
SurfaceManager. With this change, CompositorFrameSinkSupport keeps a set
of all child FrameSinkIds, and Unregisters the FrameSinks at destruction if
any remain.

BUG=666481
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2016-12-06 19:51:41]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-12-06 19:51:53]

fsamuel@chromium.org changed reviewers:
+ kylechar@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:52:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2016-12-06 20:00:17]

fsamuel@chromium.org changed reviewers:
+ piman@chromium.org

[Fady Samuel, 2016-12-06 20:00:18]

+piman@ for OWNERs

[commit-bot: I haz the power, 2016-12-06 20:51:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 20:51:36]

Dry run: This issue passed the CQ dry run.

[kylechar, 2016-12-06 21:03:57]

lgtm

[piman, 2016-12-06 21:15:11]

LGTM to fix things. But would it be useful to do this in
SurfaceManager::InvalidateFrameSinkId(parent_frame_sink_id) instead, so that we
don't need to track parent/child relationships in 2 places?

[Fady Samuel, 2016-12-06 21:20:03]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:20:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 21:27:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481059203037160, "parent_rev":
"654205eaeb6ef4785ad81c183a8b35a589f7ef09", "commit_rev":
"9a827ce53fd6970c144c8cd58619c395b1f25985"}

[commit-bot: I haz the power, 2016-12-06 21:28:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 21:32:04]

Description was changed from

==========
cc: Unregister FrameSink hierarchy on CompositorFrameSinkSupport destruction

A CompositorFrameSinkSupport may be destroyed during test tear down without
Unregistering all BeginFrame children. This causes a DCHECK to fail in
SurfaceManager. With this change, CompositorFrameSinkSupport keeps a set
of all child FrameSinkIds, and Unregisters the FrameSinks at destruction if
any remain.

BUG=666481
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Unregister FrameSink hierarchy on CompositorFrameSinkSupport destruction

A CompositorFrameSinkSupport may be destroyed during test tear down without
Unregistering all BeginFrame children. This causes a DCHECK to fail in
SurfaceManager. With this change, CompositorFrameSinkSupport keeps a set
of all child FrameSinkIds, and Unregisters the FrameSinks at destruction if
any remain.

BUG=666481
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/15ee57778085a2abef4a6548cd79c28daa16e3c3
Cr-Commit-Position: refs/heads/master@{#436735}
==========

[commit-bot: I haz the power, 2016-12-06 21:32:05]

Patchset 1 (id:??) landed as
https://crrev.com/15ee57778085a2abef4a6548cd79c28daa16e3c3
Cr-Commit-Position: refs/heads/master@{#436735}