Chromium Code Reviews
DescriptionRevert of Remove ContextLifecycleObserver from ScriptPromisePropertyBase (patchset #1 id:1 of https://codereview.chromium.org/2555873004/ )
Reason for revert:
This caused us to start failing the following tests on WebKit Linux Trusty Leak (verified by local bisect):
virtual/service-worker-navigation-preload/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html
virtual/mojo-loading/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/ready.html
imported/wpt/service-workers/service-worker/ready.https.html
http/tests/serviceworker/ready.html
First failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/559
Original issue's description:
> Remove ContextLifecycleObserver from ScriptPromisePropertyBase
>
> ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver.
> It can just hold a strong member to ExecutionContext.
>
> BUG=610176
>
> Committed: https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913
> Cr-Commit-Position: refs/heads/master@{#436950}
TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176
Committed: https://crrev.com/4383bedae77f70cdb2b22ad5dd684385f835d501
Cr-Commit-Position: refs/heads/master@{#437076}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
|||||||||||||||||||||||||||||||||||||