Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2557793004: Revert of Remove ContextLifecycleObserver from ScriptPromisePropertyBase (Closed)

Created:
4 years ago by flackr
Modified:
4 years ago
Reviewers:
haraken, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove ContextLifecycleObserver from ScriptPromisePropertyBase (patchset #1 id:1 of https://codereview.chromium.org/2555873004/ ) Reason for revert: This caused us to start failing the following tests on WebKit Linux Trusty Leak (verified by local bisect): virtual/service-worker-navigation-preload/http/tests/serviceworker/ready.html fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html fast/dom/Window/property-access-on-cached-window-after-frame-removed.html fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html virtual/mojo-loading/http/tests/serviceworker/ready.html fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html virtual/disable-mojo-service-worker/http/tests/serviceworker/ready.html imported/wpt/service-workers/service-worker/ready.https.html http/tests/serviceworker/ready.html First failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/559 Original issue's description: > Remove ContextLifecycleObserver from ScriptPromisePropertyBase > > ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver. > It can just hold a strong member to ExecutionContext. > > BUG=610176 > > Committed: https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913 > Cr-Commit-Position: refs/heads/master@{#436950} TBR=sigbjornf@opera.com,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=610176 Committed: https://crrev.com/4383bedae77f70cdb2b22ad5dd684385f835d501 Cr-Commit-Position: refs/heads/master@{#437076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h View 4 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp View 4 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
flackr
Created Revert of Remove ContextLifecycleObserver from ScriptPromisePropertyBase
4 years ago (2016-12-07 22:05:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557793004/1
4 years ago (2016-12-07 22:05:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 22:06:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4383bedae77f70cdb2b22ad5dd684385f835d501 Cr-Commit-Position: refs/heads/master@{#437076}
4 years ago (2016-12-07 22:10:18 UTC) #7
haraken
4 years ago (2016-12-08 01:06:29 UTC) #8
Message was sent while issue was closed.
Thanks, LGTM to revert.

Powered by Google App Engine
This is Rietveld 408576698