Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2557763003: DevTools: sort completions by prototype. (Closed)
Patch Set: rebaselined Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
index 2d71f679032e106380347ad2878843908c6e5d64..fed096b7a6e8d1fc123fefee008fcf0509b9c2e8 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
@@ -70,14 +70,13 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
var scopeChain = callFrame.scopeChain();
for (var i = 0; i < scopeChain.length; ++i) {
var scope = scopeChain[i];
- var title = null;
+ var title = scope.typeName();
var emptyPlaceholder = null;
var extraProperties = [];
switch (scope.type()) {
case Protocol.Debugger.ScopeType.Local:
foundLocalScope = true;
- title = Common.UIString('Local');
emptyPlaceholder = Common.UIString('No Variables');
if (thisObject)
extraProperties.push(new SDK.RemoteObjectProperty('this', thisObject));
@@ -104,21 +103,6 @@ Sources.ScopeChainSidebarPane = class extends UI.VBox {
title = Common.UIString('Closure');
emptyPlaceholder = Common.UIString('No Variables');
break;
- case Protocol.Debugger.ScopeType.Catch:
- title = Common.UIString('Catch');
- break;
- case Protocol.Debugger.ScopeType.Block:
- title = Common.UIString('Block');
- break;
- case Protocol.Debugger.ScopeType.Script:
- title = Common.UIString('Script');
- break;
- case Protocol.Debugger.ScopeType.With:
- title = Common.UIString('With Block');
- break;
- case Protocol.Debugger.ScopeType.Global:
- title = Common.UIString('Global');
- break;
}
var subtitle = scope.description();

Powered by Google App Engine
This is Rietveld 408576698