DevTools: sort completions by prototype.

third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1130 matching lines @@
      * @this {SDK.DebuggerModel.CallFrame}
      */
     function protocolCallback(error, callFrames, asyncStackTrace) {
       if (!error)
         this.debuggerModel.stepInto();
       if (callback)
         callback(error);
     }
     this._debuggerAgent.restartFrame(this._payload.callFrameId, protocolCallback.bind(this));
   }
-
-  /**
-   * @param {function(!Object)} callback
-   */
-  variableNames(callback) {
-    var result = {this: true};
-
-    function propertiesCollected(properties) {
-      for (var i = 0; properties && i < properties.length; ++i)
-        result[properties[i].name] = true;
-      if (--pendingRequests === 0)
-        callback(result);
-    }
-
-    var scopeChain = this.scopeChain();
-    var pendingRequests = scopeChain.length;
-    for (var i = 0; i < scopeChain.length; ++i) {
-      var scope = scopeChain[i];
-      var object = scope.object();
-      object.getAllProperties(false, propertiesCollected);
-    }
-  }
 };
 
 
 /**
  * @unrestricted
  */
 SDK.DebuggerModel.Scope = class {
   /**
    * @param {!SDK.DebuggerModel.CallFrame} callFrame
    * @param {number} ordinal
@@ skipping 20 matching lines @@
   }
 
   /**
    * @return {string}
    */
   type() {
     return this._type;
   }
 
   /**
+   * @return {string}
+   */
+  typeName() {
+    switch (this._type) {
+      case Protocol.Debugger.ScopeType.Local:
+        return Common.UIString('Local');
+      case Protocol.Debugger.ScopeType.Closure:
+        return Common.UIString('Closure');
+      case Protocol.Debugger.ScopeType.Catch:
+        return Common.UIString('Catch');
+      case Protocol.Debugger.ScopeType.Block:
+        return Common.UIString('Block');
+      case Protocol.Debugger.ScopeType.Script:
+        return Common.UIString('Script');
+      case Protocol.Debugger.ScopeType.With:
+        return Common.UIString('With Block');
+      case Protocol.Debugger.ScopeType.Global:
+        return Common.UIString('Global');
+    }
+    return '';

[einbinder, 2016/12/07 20:10:51]

Fails silently. Maybe a warning?

[pfeldman, 2016/12/08 00:29:06]

We don't really do asserts for code correctness in places like this.

+  }
+
+
+  /**
    * @return {string|undefined}
    */
   name() {
     return this._name;
   }
 
   /**
    * @return {?SDK.DebuggerModel.Location}
    */
   startLocation() {
@@ skipping 82 matching lines @@
         stack.callFrames.shift();
       if (previous && !stack.callFrames.length)
         previous.parent = stack.parent;
       else
         previous = stack;
       stack = stack.parent;
     }
     return asyncStackTrace;
   }
 };