Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2557743010:
Roll third_party/icu from dda089a to 73e2473 (Closed)
|
Created:
4 years ago by jungshik at Google Modified:
4 years ago Reviewers:
Mark Mentovai CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll third_party/icu from dda089a to 73e2473
http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473
Two changes are in the range:
1. Timezone update to 2016i
2. Bign Endian support for MIPS
BUG=473288
TBR=mark@chromium.org
TEST=Try the following in d8 or Chrome's JS console:
> (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone:
"Europe/Saratov"})
"12/4/2016, 4:00:00 PM"
> (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone:
"Europe/Saratov"})
"12/3/2016, 3:00:00 PM"
Committed: https://crrev.com/64a8d3b52250488714bd708f7ea91aa5d739b626
Cr-Commit-Position: refs/heads/master@{#437788}
Patch Set 1 #Messages
Total messages: 16 (9 generated)
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Roll third_party/icu from dda089a to 73e2473 http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473 Two changes are in the range: 1. Timezone update to 2016i 2. Bign Endian support for MIPS BUG=473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" ========== to ========== Roll third_party/icu from dda089a to 73e2473 http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473 Two changes are in the range: 1. Timezone update to 2016i 2. Bign Endian support for MIPS BUG=473288 TBR=mark@chromium.org TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" ==========
jshin@chromium.org changed reviewers: + mark@chromium.org
The CQ bit was checked by jshin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481455157440530, "parent_rev":
"1f77cf0af97510545733c00ec3526b9fab43eb18", "commit_rev":
"bd8c9c1c1a3c744a02d390b2b24da77993838b83"}
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/icu from dda089a to 73e2473 http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473 Two changes are in the range: 1. Timezone update to 2016i 2. Bign Endian support for MIPS BUG=473288 TBR=mark@chromium.org TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" ========== to ========== ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
LGTM
Message was sent while issue was closed.
Description was changed from ========== ========== to ========== Roll third_party/icu from dda089a to 73e2473 http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473 Two changes are in the range: 1. Timezone update to 2016i 2. Bign Endian support for MIPS BUG=473288 TBR=mark@chromium.org TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" ==========
Message was sent while issue was closed.
Description was changed from ========== Roll third_party/icu from dda089a to 73e2473 http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473 Two changes are in the range: 1. Timezone update to 2016i 2. Bign Endian support for MIPS BUG=473288 TBR=mark@chromium.org TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" ========== to ========== Roll third_party/icu from dda089a to 73e2473 http://chromium.googlesource.com/chromium/deps/icu.git/+log/dda089a..73e2473 Two changes are in the range: 1. Timezone update to 2016i 2. Bign Endian support for MIPS BUG=473288 TBR=mark@chromium.org TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" Committed: https://crrev.com/64a8d3b52250488714bd708f7ea91aa5d739b626 Cr-Commit-Position: refs/heads/master@{#437788} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/64a8d3b52250488714bd708f7ea91aa5d739b626 Cr-Commit-Position: refs/heads/master@{#437788}
Message was sent while issue was closed.
On 2016/12/12 15:09:39, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/64a8d3b52250488714bd708f7ea91aa5d739b626 > Cr-Commit-Position: refs/heads/master@{#437788} I had a typo in the CL description. It is 2016j (not 2016i) that's included in this ICU roll. |
