Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2557743005: Remove unused cassert include in base/numerics/safe_conversions.h (Closed)

Created:
4 years ago by scottmg
Modified:
4 years ago
Reviewers:
jschuh
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused cassert include in base/numerics/safe_conversions.h assert() does not appear in base/numerics. Noticed while trying to roll Chromium numerics into mini_chromium to roll mini_chromium into Crashpad to upstream https://codereview.chromium.org/2528243002 into Crashpad to roll Crashpad back into Chromium. Sigh. BUG=668713 R=jschuh@chromium.org Committed: https://crrev.com/1bb44b3c5f9bc262640a686ad8bbfec284902142 Cr-Commit-Position: refs/heads/master@{#437240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M base/numerics/safe_conversions.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
scottmg
4 years ago (2016-12-07 21:54:22 UTC) #2
jschuh
On 2016/12/07 21:54:22, scottmg wrote: Oops. This one was just a mistake, because I ended ...
4 years ago (2016-12-08 14:04:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557743005/1
4 years ago (2016-12-08 14:04:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 14:09:50 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 14:13:20 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bb44b3c5f9bc262640a686ad8bbfec284902142
Cr-Commit-Position: refs/heads/master@{#437240}

Powered by Google App Engine
This is Rietveld 408576698