Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Unified Diff: dashboard/dashboard/elements/alerts-page.html

Issue 2557743004: Adding in abs delta column to the alerts table (Closed)
Patch Set: adding in tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/alerts.py ('k') | dashboard/dashboard/elements/alerts-page-test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/alerts-page.html
diff --git a/dashboard/dashboard/elements/alerts-page.html b/dashboard/dashboard/elements/alerts-page.html
index ba0d715d6cfe226cb2f6c869c5cc26c868c15eb7..f38dca9a1e61f3f7f855f4d4a0bdd9a0c240b77f 100644
--- a/dashboard/dashboard/elements/alerts-page.html
+++ b/dashboard/dashboard/elements/alerts-page.html
@@ -16,6 +16,8 @@ found in the LICENSE file.
<link rel="import" href="/dashboard/static/simple_xhr.html">
<link rel="import" href="/dashboard/static/uri.html">
+<link rel="import" href="/tracing/base/unit.html">
+
<dom-module id="alerts-page">
<template>
<style>
@@ -170,10 +172,20 @@ found in the LICENSE file.
extraAnomaliesColumns: {
type: Array,
notify: true,
- value: () => ([{
- 'key': 'percent_changed',
- 'label': 'Delta %'
- }])
+ value: () => ([
+ {
+ 'key': 'percent_changed',
+ 'label': 'Delta %'
+ },
+ {
+ 'key': 'absolute_delta',
+ 'label': 'Abs Delta'
+ },
+ {
+ 'key': 'units',
+ 'label': 'Units'
+ }
+ ])
},
extraStoppageAlertsColumns: {
@@ -212,7 +224,7 @@ found in the LICENSE file.
computeIsSingular: array => array.length === 1,
- getLabel: toggleState => toggleState ? 'hide' : 'show',
+ getLabel: toggleState => (toggleState ? 'hide' : 'show'),
onSheriffChange: function(e) {
var sheriff = e.detail.item.label;
« no previous file with comments | « dashboard/dashboard/alerts.py ('k') | dashboard/dashboard/elements/alerts-page-test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698