[serializer] include global proxy in additional context snapshots.

[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to have the ability to replace the global proxy and global object
after deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
Committed: https://crrev.com/98b563ebf3fe39740970416691d8220c91cf599e
Cr-Commit-Position: refs/heads/master@{#41588}

[Yang, 2016-12-07 09:31:46]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 09:31:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-07 09:32:25]

Description was changed from

==========
[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to be able to replace the global proxy and global object after
deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

to

==========
[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to have the ability to replace the global proxy and global object
after deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

[jochen (gone - plz use gerrit), 2016-12-07 09:34:14]

lgtm

[commit-bot: I haz the power, 2016-12-07 09:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 09:40:54]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/13815)

[Yang, 2016-12-07 09:43:24]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-07 09:43:25]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2557743003/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-12-07 09:43:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2016-12-07 10:11:08]

Code LGTM % an API document.

https://codereview.chromium.org/2557743003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2557743003/diff/1/include/v8.h#newcode7904
include/v8.h:7904: * deserialize from. It must be larger than 0. Use
v8::Context::New for the
According to tests, we can use 0 for this index, right?

[Yang, 2016-12-07 10:11:37]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2016-12-07 10:13:05]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-12-07 10:13:05]

The patchset sent to the CQ was uploaded after l-g-t-m from peria@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2557743003/#ps40001
(title: "fix comment")

[commit-bot: I haz the power, 2016-12-07 10:13:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-12-07 10:13:34]

https://codereview.chromium.org/2557743003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2557743003/diff/1/include/v8.h#newcode7904
include/v8.h:7904: * deserialize from. It must be larger than 0. Use
v8::Context::New for the
On 2016/12/07 10:11:08, peria wrote:
> According to tests, we can use 0 for this index, right?

Nice catch. The comment is outdated. Fixed.

[peria, 2016-12-07 10:14:09]

lgtm

[commit-bot: I haz the power, 2016-12-07 11:06:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 11:06:19]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_arm_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...)

[Yang, 2016-12-08 12:16:36]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-12-08 12:16:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 12:44:30]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481199396425610,
"parent_rev": "1188992885877807ddfe468f713a99633740010b", "commit_rev":
"89bfd0cd3ef91ad34d40771256cfe5fe88a11fcc"}

[commit-bot: I haz the power, 2016-12-08 12:44:37]

Description was changed from

==========
[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to have the ability to replace the global proxy and global object
after deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

to

==========
[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to have the ability to replace the global proxy and global object
after deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

[commit-bot: I haz the power, 2016-12-08 12:44:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 12:45:09]

Description was changed from

==========
[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to have the ability to replace the global proxy and global object
after deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892
==========

to

==========
[serializer] include global proxy in additional context snapshots.

Aside from the default snapshot, there is no need for additional context
snapshots to have the ability to replace the global proxy and global object
after deserialization. Changes include:
 - Changes to the API to better distinguish default context snapshot from
   additional context snapshots.
 - Disallow global handles when creating snapshots.
 - Allow extensions when creating snapshots.

This solves the issue of not being able to having accessors and interceptors on
the global object of contexts to be serialized.

R=jochen@chromium.org, peria@chromium.org
BUG=chromium:617892

Committed: https://crrev.com/98b563ebf3fe39740970416691d8220c91cf599e
Cr-Commit-Position: refs/heads/master@{#41588}
==========

[commit-bot: I haz the power, 2016-12-08 12:45:10]

Patchset 3 (id:??) landed as
https://crrev.com/98b563ebf3fe39740970416691d8220c91cf599e
Cr-Commit-Position: refs/heads/master@{#41588}