Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: base/trace_event/trace_config.h

Issue 2557743002: tracing: simplify lifetime of TraceEventFilter(s) (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/trace_config.h
diff --git a/base/trace_event/trace_config.h b/base/trace_event/trace_config.h
index 7db09fca79bc28fdd2af5fd1ed01954a6a8c5cdf..52286024cf7553d8a0ce4644df44411553de47a4 100644
--- a/base/trace_event/trace_config.h
+++ b/base/trace_event/trace_config.h
@@ -17,6 +17,7 @@
#include "base/gtest_prod_util.h"
#include "base/strings/string_piece.h"
#include "base/trace_event/memory_dump_request_args.h"
+#include "base/trace_event/trace_event_filter.h"
#include "base/values.h"
namespace base {
@@ -84,12 +85,12 @@ class BASE_EXPORT TraceConfig {
HeapProfiler heap_profiler_options;
};
- class EventFilterConfig {
+ class EventFilterConfig : public TraceEventFilter::Config {
public:
EventFilterConfig(const std::string& predicate_name);
EventFilterConfig(const EventFilterConfig& tc);
- ~EventFilterConfig();
+ ~EventFilterConfig() override;
EventFilterConfig& operator=(const EventFilterConfig& rhs);
@@ -109,6 +110,9 @@ class BASE_EXPORT TraceConfig {
return excluded_categories_;
}
+ // TraceEventFilter::CategoryConfig implementation.
+ bool IsEnabledForCategory(const char* category_name) const override;
+
private:
std::string predicate_name_;
StringList included_categories_;

Powered by Google App Engine
This is Rietveld 408576698