base/trace_event/heap_profiler_event_filter.h - Issue 2557743002: tracing: simplify lifetime of TraceEventFilter(s)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/heap_profiler_event_filter.h

Issue 2557743002: tracing: simplify lifetime of TraceEventFilter(s) (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/heap_profiler_event_filter.h

diff --git a/base/trace_event/heap_profiler_event_filter.h b/base/trace_event/heap_profiler_event_filter.h

index 47368a1b0702da38c03a871017bf818b6c1bf93f..09283d9d573df386b4922a5f816349e2da7c4b82 100644

--- a/base/trace_event/heap_profiler_event_filter.h

+++ b/base/trace_event/heap_profiler_event_filter.h

@@ -22,7 +22,7 @@ class BASE_EXPORT HeapProfilerEventFilter : public TraceEventFilter {

public:

static const char kName[];

- HeapProfilerEventFilter();

+ explicit HeapProfilerEventFilter(std::unique_ptr<TraceEventFilter::Config>);

~HeapProfilerEventFilter() override;

// TraceEventFilter implementation.