[Sync] Remove entry from SMTP::storage_key_to_tag_hash_ when deleting tracker

[Sync] Remove entry from SMTP::storage_key_to_tag_hash_ when deleting tracker

The issue is that entry in storage_key_to_tag_hash_ is not erased when entity
tracker is removed from entities_. Because of this CreateEntry DCHECKs when
entity is deleted and then recreated.

BUG=671211
R=maxbogue@chromium.org

Committed: https://crrev.com/c26668deea2b1dbfcba8efc40d40f9598eed57c2
Cr-Commit-Position: refs/heads/master@{#436696}

[pavely, 2016-12-06 19:00:17]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 19:00:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-12-06 19:36:49]

lgtm

[pavely, 2016-12-06 19:40:00]

The CQ bit was unchecked by pavely@chromium.org

[pavely, 2016-12-06 19:40:00]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:40:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 20:30:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481053200686180, "parent_rev":
"6dad5d222bb61e0fc1139c25409ca64b2862d57f", "commit_rev":
"ae8793f11b50be36a376c5ad6fc99cf751349a93"}

[commit-bot: I haz the power, 2016-12-06 20:31:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 20:35:17]

Description was changed from

==========
[Sync] Remove entry from SMTP::storage_key_to_tag_hash_ when deleting tracker

The issue is that entry in storage_key_to_tag_hash_ is not erased when entity
tracker is removed from entities_. Because of this CreateEntry DCHECKs when
entity is deleted and then recreated.

BUG=671211
R=maxbogue@chromium.org
==========

to

==========
[Sync] Remove entry from SMTP::storage_key_to_tag_hash_ when deleting tracker

The issue is that entry in storage_key_to_tag_hash_ is not erased when entity
tracker is removed from entities_. Because of this CreateEntry DCHECKs when
entity is deleted and then recreated.

BUG=671211
R=maxbogue@chromium.org

Committed: https://crrev.com/c26668deea2b1dbfcba8efc40d40f9598eed57c2
Cr-Commit-Position: refs/heads/master@{#436696}
==========

[commit-bot: I haz the power, 2016-12-06 20:35:17]

Patchset 1 (id:??) landed as
https://crrev.com/c26668deea2b1dbfcba8efc40d40f9598eed57c2
Cr-Commit-Position: refs/heads/master@{#436696}