Avoid bigints entering non-bigint gcd implementation.

Avoid bigints entering non-bigint gcd implementation.

R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/3eee2e69b27c5f9b737bd5128d6a06d0c8035031

[Lasse Reichstein Nielsen, 2016-12-06 09:05:22]

lrn@google.com changed reviewers:
+ asiva@google.com

[Lasse Reichstein Nielsen, 2016-12-06 09:05:23]

https://codereview.chromium.org/2557713002/diff/1/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/2557713002/diff/1/runtime/lib/integers.dart#n...
runtime/lib/integers.dart:398: return x._toBigint().gcd(y);
If other is -0x8000000000000000 (aka min-mint) then y == -other is a bigint, but
other is not. Similar for `this` and `x`. Might as well go to the bigint
implementation (and avoid doing the negation again).

[siva, 2016-12-06 16:53:35]

asiva@google.com changed reviewers:
+ regis@google.com

[siva, 2016-12-06 16:53:36]

+regis

[regis, 2016-12-06 17:08:15]

lgtm

https://codereview.chromium.org/2557713002/diff/1/runtime/lib/integers.dart
File runtime/lib/integers.dart (right):

https://codereview.chromium.org/2557713002/diff/1/runtime/lib/integers.dart#n...
runtime/lib/integers.dart:398: return x._toBigint().gcd(y);
On 2016/12/06 09:05:23, Lasse Reichstein Nielsen wrote:
> If other is -0x8000000000000000 (aka min-mint) then y == -other is a bigint,
but
> other is not. Similar for `this` and `x`. Might as well go to the bigint
> implementation (and avoid doing the negation again).

Agreed.

[Lasse Reichstein Nielsen, 2016-12-08 06:37:20]

Description was changed from

==========
Avoid bigints entering non-bigint gcd implementation.
==========

to

==========
Avoid bigints entering non-bigint gcd implementation.

R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3eee2e69b27c5f9b737bd5128d6a06d0c8035031
==========

[Lasse Reichstein Nielsen, 2016-12-08 06:37:21]

Committed patchset #1 (id:1) manually as
3eee2e69b27c5f9b737bd5128d6a06d0c8035031 (presubmit successful).