Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2557703002: Revert of Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() (patchset #3 id:180001 of https://codereview.chromium.org/2511883003/ ) Reason for revert: Build failure on Linux ChromiumOS Builder (dbg). https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20(dbg)/builds/81360 Original issue's description: > Use mojo typemaps to simplify arc::IntentFilter::IntentFilter() > > BUG=665719 > > Committed: https://crrev.com/6d90e3c056d091756ae21d32a85c843350310878 > Cr-Commit-Position: refs/heads/master@{#436545} TBR=yusukes@chromium.org,lhchavez@chromium.org,djacobo@chromium.org,hidehiko@chromium.org,dcheng@chromium.org,yoshiki@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665719 Committed: https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e Cr-Commit-Position: refs/heads/master@{#436546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -265 lines) Patch
D components/arc/common/intent_helper.typemap View 1 chunk +0 lines, -16 lines 0 comments Download
M components/arc/common/typemaps.gni View 1 chunk +0 lines, -1 line 0 comments Download
D components/arc/intent_helper/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/intent_helper/arc_intent_helper_bridge_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/arc/intent_helper/intent_filter.h View 2 chunks +10 lines, -45 lines 0 comments Download
M components/arc/intent_helper/intent_filter.cc View 3 chunks +21 lines, -30 lines 0 comments Download
D components/arc/intent_helper/intent_filter_struct_traits.h View 1 chunk +0 lines, -79 lines 0 comments Download
D components/arc/intent_helper/intent_filter_struct_traits.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M components/arc/intent_helper/intent_filter_unittest.cc View 1 chunk +18 lines, -9 lines 0 comments Download
M components/arc/intent_helper/local_activity_resolver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/intent_helper/local_activity_resolver.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/arc/intent_helper/local_activity_resolver_unittest.cc View 5 chunks +23 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Created Revert of Use mojo typemaps to simplify arc::IntentFilter::IntentFilter()
4 years ago (2016-12-06 08:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557703002/1
4 years ago (2016-12-06 08:58:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 08:59:57 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-06 09:02:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbcd7bf6139fb6b95e65b28497ea3c24c8b76f2e
Cr-Commit-Position: refs/heads/master@{#436546}

Powered by Google App Engine
This is Rietveld 408576698