Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2557693006: [turbofan] Remove --turbo-asm-deoptimization flag. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove --turbo-asm-deoptimization flag. R=bmeurer@chromium.org,titzer@chromium.org Committed: https://crrev.com/7854e64908a59fdb29ee27e362a95d2561f694be Cr-Commit-Position: refs/heads/master@{#41579}

Patch Set 1 #

Patch Set 2 : Remove implication. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -33 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-frames.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D test/mjsunit/compiler/regress-uint8-deopt.js View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Benedikt Meurer
AWESOME! LGTM.
4 years ago (2016-12-08 06:55:11 UTC) #5
Yang
On 2016/12/08 06:55:11, Benedikt Meurer wrote: > AWESOME! LGTM. LGTM.
4 years ago (2016-12-08 07:52:29 UTC) #6
Michael Starzinger
4 years ago (2016-12-08 09:18:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557693006/20001
4 years ago (2016-12-08 09:18:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 09:21:04 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-08 09:21:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7854e64908a59fdb29ee27e362a95d2561f694be
Cr-Commit-Position: refs/heads/master@{#41579}

Powered by Google App Engine
This is Rietveld 408576698