Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2557643002: Apply hyphenation when there is only one word in a paragraph (Closed)

Created:
4 years ago by kojii
Modified:
4 years ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply hyphenation when there is only one word in a paragraph The logic not to hyphenate the last word in a paragraph also prevented single word in a paragraph from being hyphenated. This patch hyphenates the single word case, as an exception to the orphaned word. This is the same behavior with WebKit. This patch also fixes not to hyphenate the last word when followed by spaces. BUG=671125 Committed: https://crrev.com/f16ecaf4fc414d951fe9b1699d96e7eba3eab13a Cr-Commit-Position: refs/heads/master@{#436926}

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : WIP #

Patch Set 4 : Cleanup, add test #

Patch Set 5 : Add a static helper function #

Messages

Total messages: 22 (17 generated)
kojii
PTAL. I'm preparing another fix, but this one looks bad enough to merge to M56, ...
4 years ago (2016-12-06 14:56:14 UTC) #10
eae
LGTM
4 years ago (2016-12-07 07:17:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557643002/80001
4 years ago (2016-12-07 12:43:34 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-12-07 12:48:41 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-07 12:50:24 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f16ecaf4fc414d951fe9b1699d96e7eba3eab13a
Cr-Commit-Position: refs/heads/master@{#436926}

Powered by Google App Engine
This is Rietveld 408576698