gpu: Refactor and cleanup CHROMIUM_copy_texture implementation.

gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
 #define GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_
 
+#include <map>
+
 #include "gpu/command_buffer/service/gl_utils.h"
 #include "gpu/gpu_export.h"
 
 namespace gpu {
 namespace gles2 {
 
 class GLES2Decoder;
 
 }  // namespace gles2.
 
 // This class encapsulates the resources required to implement the
 // GL_CHROMIUM_copy_texture extension.  The copy operation is performed
 // via a blit to a framebuffer object.
 class GPU_EXPORT CopyTextureCHROMIUMResourceManager {
  public:
   CopyTextureCHROMIUMResourceManager();
+  ~CopyTextureCHROMIUMResourceManager();
 
   void Initialize(const gles2::GLES2Decoder* decoder);
   void Destroy();
 
   void DoCopyTexture(const gles2::GLES2Decoder* decoder, GLenum source_target,
                      GLenum dest_target, GLuint source_id, GLuint dest_id,
                      GLint level, GLsizei width, GLsizei height,
                      bool flip_y, bool premultiply_alpha,
                      bool unpremultiply_alpha);
 
   // This will apply a transform on the source texture before copying to
   // destination texture.
   void DoCopyTextureWithTransform(const gles2::GLES2Decoder* decoder,
                                   GLenum source_target, GLenum dest_target,
                                   GLuint source_id, GLuint dest_id, GLint level,
                                   GLsizei width, GLsizei height, bool flip_y,
                                   bool premultiply_alpha,
                                   bool unpremultiply_alpha,
                                   const GLfloat transform_matrix[16]);
 
   // The attributes used during invocation of the extension.
   static const GLuint kVertexPositionAttrib = 0;
 
  private:
+  struct ProgramInfo {
+    ProgramInfo() : program(0u), matrix_handle(0u), sampler_locations(0u) {}
+
+    GLuint program;
+    GLuint matrix_handle;
+    GLuint sampler_locations;
+  };
+
   bool initialized_;
-
-  static const int kNumPrograms = 12;
-  GLuint programs_[kNumPrograms];
+  typedef std::pair<int, int> ProgramMapKey;
+  typedef std::map<ProgramMapKey, ProgramInfo> ProgramMap;

[piman, 2014/04/25 03:30:40]

nit: hash_map, or even SmallMap.

[reveman, 2014/04/25 20:27:10]

Done.

+  ProgramMap programs_;
   GLuint buffer_id_;
   GLuint framebuffer_;
-  GLuint matrix_handle_[kNumPrograms];
-  GLuint sampler_locations_[kNumPrograms];
+  GLuint vertex_shader_;
 
   DISALLOW_COPY_AND_ASSIGN(CopyTextureCHROMIUMResourceManager);
 };
 
 }  // namespace gpu.
 
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_COPY_TEXTURE_CHROMIUM_H_