ImageCapture: queue requests if device is not started (Linux,CrOs)

ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux,
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a
while and happens asynchronously.

BUG=670262, 627537
Committed: https://crrev.com/ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6
Cr-Commit-Position: refs/heads/master@{#436684}

[mcasas, 2016-12-06 02:00:07]

Description was changed from

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

BUG=670262
==========

to

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related 
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux, 
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a 
while and happens asynchronously.

BUG=670262
==========

[mcasas, 2016-12-06 02:03:01]

Description was changed from

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related 
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux, 
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a 
while and happens asynchronously.

BUG=670262
==========

to

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related 
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux, 
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a 
while and happens asynchronously.

BUG=670262, 627537
==========

[mcasas, 2016-12-06 03:32:05]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-12-06 03:32:05]

xianglu@ PTAL

[mcasas, 2016-12-06 03:58:30]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 03:58:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 04:38:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 04:38:32]

Dry run: This issue passed the CQ dry run.

[xianglu, 2016-12-06 18:18:03]

LGTM with one comment.

https://codereview.chromium.org/2557623002/diff/1/media/capture/video/linux/v...
File media/capture/video/linux/video_capture_device_linux.cc (right):

https://codereview.chromium.org/2557623002/diff/1/media/capture/video/linux/v...
media/capture/video/linux/video_capture_device_linux.cc:91: auto functor =
base::Bind(&V4L2CaptureDelegate::TakePhoto, capture_impl_,
s/functor/callback/ ?

[mcasas, 2016-12-06 19:21:03]

https://codereview.chromium.org/2557623002/diff/1/media/capture/video/linux/v...
File media/capture/video/linux/video_capture_device_linux.cc (right):

https://codereview.chromium.org/2557623002/diff/1/media/capture/video/linux/v...
media/capture/video/linux/video_capture_device_linux.cc:91: auto functor =
base::Bind(&V4L2CaptureDelegate::TakePhoto, capture_impl_,
On 2016/12/06 18:18:03, xianglu wrote:
> s/functor/callback/ ?

Yeah, but |callback| is a parameter... couldn't come up with an 
alternative name TBH.

[mcasas, 2016-12-06 19:21:08]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:21:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 19:27:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481052068079850, "parent_rev":
"ca5a468bb7308106cd20af2168a05e020f4bbcb4", "commit_rev":
"cda9c59fe4f43bde0f0713a10cb23bb5076511fb"}

[commit-bot: I haz the power, 2016-12-06 19:27:47]

Description was changed from

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related 
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux, 
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a 
while and happens asynchronously.

BUG=670262, 627537
==========

to

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related 
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux, 
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a 
while and happens asynchronously.

BUG=670262, 627537
==========

[commit-bot: I haz the power, 2016-12-06 19:27:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 19:31:29]

Description was changed from

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related 
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux, 
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a 
while and happens asynchronously.

BUG=670262, 627537
==========

to

==========
ImageCapture: queue requests if device is not started (Linux,CrOs)

This CL is the continuation of https://crrev.com/2193213003
for CrOs. Said CL added a queue of image-capture related
requests in VideoCaptureManager and in VideoCaptureDeviceAndroid,
this CL adds such a queue in VideoCaptureDeviceLinux,
otherwise (see bug) there is a race between the photo
related requests and the device startup, which can take a
while and happens asynchronously.

BUG=670262, 627537

Committed: https://crrev.com/ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6
Cr-Commit-Position: refs/heads/master@{#436684}
==========

[commit-bot: I haz the power, 2016-12-06 19:31:30]

Patchset 1 (id:??) landed as
https://crrev.com/ba3e7171459cfa4bc9c0c26329a88ff3a4c21bd6
Cr-Commit-Position: refs/heads/master@{#436684}