Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2557613004: [ios] Adds test hooks to enable/disable functionality while testing. (Closed)

Created:
4 years ago by rohitrao (ping after 24h)
Modified:
4 years ago
Reviewers:
*baxley, sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Adds test hooks to enable/disable functionality while testing. BUG=671589 Committed: https://crrev.com/dfb38253441460834d4667833f7a25a884ac5a68 Cr-Commit-Position: refs/heads/master@{#436603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M ios/chrome/app/BUILD.gn View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/chrome/app/tests_fake_hook.mm View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/chrome/app/tests_hook.h View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
rohitrao (ping after 24h)
4 years ago (2016-12-06 13:35:38 UTC) #5
sdefresne
lgtm
4 years ago (2016-12-06 13:37:34 UTC) #6
baxley
lgtm
4 years ago (2016-12-06 15:27:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557613004/1
4 years ago (2016-12-06 15:30:21 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 15:34:29 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-06 15:37:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfb38253441460834d4667833f7a25a884ac5a68
Cr-Commit-Position: refs/heads/master@{#436603}

Powered by Google App Engine
This is Rietveld 408576698