Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 2557603006: Skip the sRGB mip-map testing on command buffer (Closed)

Created:
4 years ago by Brian Osman
Modified:
4 years ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Skip the sRGB mip-map testing on command buffer Chromium command buffer now has the sRGB decode extension, but it doesn't make any guarantees about the interaction with glGenerateMipmap. BUG=skia: Committed: https://skia.googlesource.com/skia/+/851c2386bad44fb6c453744d970237e681e693f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M src/gpu/gl/GrGLCaps.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/SRGBMipMapTest.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Brian Osman
4 years ago (2016-12-07 17:07:50 UTC) #4
bsalomon
lgtm
4 years ago (2016-12-07 17:38:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557603006/1
4 years ago (2016-12-07 18:01:27 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-07 18:03:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/851c2386bad44fb6c453744d970237e681e693f0

Powered by Google App Engine
This is Rietveld 408576698