Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2557593006: Update TestExpectations by running Tools/Scripts/update-test-expectations. (Closed)

Created:
4 years ago by qyearsley
Modified:
4 years ago
Reviewers:
ojan
CC:
blink-reviews, bokan, chromium-reviews, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestExpectations by running Tools/Scripts/update-test-expectations. This script removes lines for tests that appear to no longer flakily fail or timeout on the applicable platforms, according to recent results on the flakiness dashboard. BUG=248938, 446385, 513143, 518987, 522647, 532643, 564403, 569901, 581468, 605525, 658311, 658414, 660308, 667953, 671618 Committed: https://crrev.com/fdc595432d97064286db8e2bdda3d8eb2119dbfc Cr-Commit-Position: refs/heads/master@{#437038}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 15 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
qyearsley
4 years ago (2016-12-07 17:54:39 UTC) #4
ojan
lgtm
4 years ago (2016-12-07 18:18:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557593006/20001
4 years ago (2016-12-07 18:57:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 19:49:56 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fdc595432d97064286db8e2bdda3d8eb2119dbfc Cr-Commit-Position: refs/heads/master@{#437038}
4 years ago (2016-12-07 19:53:15 UTC) #14
Xianzhu
update-test-expectations seems to have done something wrong, at least for virtual/android/media/mediadocument/media-document-with-download-button.html which is still very ...
4 years ago (2016-12-08 22:52:23 UTC) #15
qyearsley
4 years ago (2016-12-08 23:01:57 UTC) #16
Message was sent while issue was closed.
On 2016/12/08 at 22:52:23, wangxianzhu wrote:
> update-test-expectations seems to have done something wrong, at least for
virtual/android/media/mediadocument/media-document-with-download-button.html
which is still very flaky:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=vir...
> 
> The issue sometimes fails the CQ.

I think I found an explanation! When I ran update-test-expectations, I saw an
error "No matching builders for line, deleting line.", which I ignored at the
time (although I probably shouldn't have).

This is because in
//third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py there's no
entry for WebKit Linux Trusty (dbg), although there should be.

Follow-up actions which I will do now:
 1. add that builder to config/builders.py
 2. re-add the line for
virtual/android/media/mediadocument/media-document-with-download-button.html

Powered by Google App Engine
This is Rietveld 408576698