[ignition] desugar GetIterator() via bytecode rather than via AST

src/compiler/ast-loop-assignment-analyzer.cc

Index: src/compiler/ast-loop-assignment-analyzer.cc
diff --git a/src/compiler/ast-loop-assignment-analyzer.cc b/src/compiler/ast-loop-assignment-analyzer.cc
index 82eaeb28a46840d5087c1b0baf1ea754282641bb..c9f4cdd739c7c804550d8870ff75f85da6c17d3b 100644
--- a/src/compiler/ast-loop-assignment-analyzer.cc
+++ b/src/compiler/ast-loop-assignment-analyzer.cc
@@ -201,6 +201,7 @@ void ALAA::VisitSpread(Spread* e) { UNREACHABLE(); }
 
 void ALAA::VisitEmptyParentheses(EmptyParentheses* e) { UNREACHABLE(); }
 
+void ALAA::VisitGetIterator(GetIterator* e) { Visit(e->iterable()); }

[adamk, 2016/12/06 18:49:05]

Isn't this just as unreachable as the AstGraphBuilder method?

[caitp, 2016/12/06 19:00:44]

We run into it in cctest/test-loop-assignment-analysis/SimpleLoop2, which runs
the ALAA regardless of whether optimization is disabled or not.

The alternative is to just remove the test, either one seems fine

[Benedikt Meurer, 2016/12/06 19:17:07]

I'd drop the test in that case.

 
 void ALAA::VisitCaseClause(CaseClause* cc) {
   if (!cc->is_default()) Visit(cc->label());