Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2557593004: [ignition] desugar GetIterator() via bytecode rather than via AST (Closed)
Patch Set: get tests passing Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc
diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
index 3a75fc0f0210a6c133ddad6d2271170dfcc75768..a6de2bfd734e1e9543b60481fae8a0fe7e386b8e 100644
--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc
+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc
@@ -202,7 +202,8 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
// Short jumps with Imm8 operands
{
- BytecodeLabel start, after_jump1, after_jump2, after_jump3, after_jump4;
+ BytecodeLabel start, after_jump1, after_jump2, after_jump3, after_jump4,
+ after_jump5;
builder.Bind(&start)
.Jump(&after_jump1)
.Bind(&after_jump1)
@@ -212,11 +213,13 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
.Bind(&after_jump3)
.JumpIfNotHole(&after_jump4)
.Bind(&after_jump4)
+ .JumpIfJSReceiver(&after_jump5)
+ .Bind(&after_jump5)
.JumpLoop(&start, 0);
}
// Longer jumps with constant operands
- BytecodeLabel end[8];
+ BytecodeLabel end[9];
{
BytecodeLabel after_jump;
builder.Jump(&end[0])
@@ -231,7 +234,9 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {
.JumpIfFalse(&end[4])
.JumpIfNull(&end[5])
.JumpIfUndefined(&end[6])
- .JumpIfNotHole(&end[7]);
+ .JumpIfNotHole(&end[7])
+ .LoadLiteral(factory->prototype_string())
rmcilroy 2016/12/06 15:02:28 nit - no need to load the literal here (the code i
caitp 2016/12/06 15:14:58 Acknowledged.
+ .JumpIfJSReceiver(&end[8]);
}
// Perform an operation that returns boolean value to

Powered by Google App Engine
This is Rietveld 408576698