third_party/WebKit/Source/core/html/HTMLInputElement.cpp - Issue 2557583003: Move Form Association Code to FormAssociated::associateWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2557583003: Move Form Association Code to FormAssociated::associateWith (Closed)

Patch Set: Check for m_inputType before accessing it Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

index dba5ef41a41c4e8c6a006f724806722e8520a8bc..1d1fc3b29b17641308b1d063597918da10c980d4 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp

@@ -1476,13 +1476,15 @@ void HTMLInputElement::updateClearButtonVisibility() {

}

void HTMLInputElement::willChangeForm() {

- removeFromRadioButtonGroup();

+ if (m_inputType)

+ removeFromRadioButtonGroup();

TextControlElement::willChangeForm();

}

void HTMLInputElement::didChangeForm() {

TextControlElement::didChangeForm();

- addToRadioButtonGroup();

+ if (m_inputType)

+ addToRadioButtonGroup();

}

Node::InsertionNotificationRequest HTMLInputElement::insertedInto(