third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp - Issue 2557583003: Move Form Association Code to FormAssociated::associateWith

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

Issue 2557583003: Move Form Association Code to FormAssociated::associateWith (Closed)

Patch Set: Check for m_inputType before accessing it Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

index 5f6d4e11c48bcd7583802123b4b76faed597561a..a80049ca2c68aa9a3ac16adcac1685cae3cadab5 100644

--- a/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp

@@ -60,7 +60,6 @@ HTMLFormControlElement::HTMLFormControlElement(const QualifiedName& tagName,

m_validityIsDirty(false),

m_wasFocusedByMouse(false) {

setHasCustomStyleCallbacks();

- associateByParser(form);

}

HTMLFormControlElement::~HTMLFormControlElement() {}

@@ -627,6 +626,8 @@ void HTMLFormControlElement::copyNonAttributePropertiesFromElement(

setNeedsValidityCheck();

}

-void HTMLFormControlElement::associateWith(HTMLFormElement*){};

+void HTMLFormControlElement::associateWith(HTMLFormElement* form) {

+ associateByParser(form);

+};

} // namespace blink

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLImageElement.cpp » ('j') | no next file with comments »