third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js - Issue 2557573002: DevTools: show name descriptions before formatted TypedArrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

Issue 2557573002: DevTools: show name descriptions before formatted TypedArrays (Closed)

Patch Set: fix test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js b/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

index 1fc9f74bbb4cc8793bd489b207c2b906132e84b8..ab921035075be6a964f385da527f261060e4d969 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js

@@ -15,12 +15,12 @@ Components.RemoteObjectPreviewFormatter = class {

parentElement.appendChild(this.renderPropertyPreview(preview.type, preview.subtype, description));

return;

}

- var isArray = preview.subtype === 'array' || preview.subtype === 'typedarray';

- if (description && !isArray) {

+ if (description && preview.subtype !== 'array') {

var text = preview.subtype ? description : this._abbreviateFullQualifiedClassName(description);

parentElement.createTextChildren(text, ' ');

}

+ var isArray = preview.subtype === 'array' || preview.subtype === 'typedarray';

parentElement.createTextChild(isArray ? '[' : '{');

if (preview.entries)

this._appendEntriesPreview(parentElement, preview);