Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2557573002: DevTools: show name descriptions before formatted TypedArrays (Closed)

Created:
4 years ago by luoe
Modified:
4 years ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: show name descriptions before formatted TypedArrays This CL adds typed array names to their formatted output. Note: in the near future, the printArrayResult() branch will be folded into RemoteObjectPreviewFormatter. BUG=632539 Committed: https://crrev.com/3991a07a09e18157dec31fc589f901e2cea2d686 Cr-Commit-Position: refs/heads/master@{#436752}

Patch Set 1 #

Patch Set 2 : DevTools: show typed array names in console.log #

Patch Set 3 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-external-array-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-expected.txt View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/RemoteObjectPreviewFormatter.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
luoe
Please take a look. There's no screenshot, but the bug describes how this will look.
4 years ago (2016-12-05 23:20:44 UTC) #3
lushnikov
lgtm
4 years ago (2016-12-06 01:25:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557573002/20001
4 years ago (2016-12-06 01:25:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/350311)
4 years ago (2016-12-06 02:45:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2557573002/40001
4 years ago (2016-12-06 21:44:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-06 21:53:30 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-06 21:56:01 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3991a07a09e18157dec31fc589f901e2cea2d686
Cr-Commit-Position: refs/heads/master@{#436752}

Powered by Google App Engine
This is Rietveld 408576698