Make calculation of document marker's rendered rect on demand

Make calculation of document marker's rendered rect on demand

Currently, when adding a document marker, we calculate its rendered
rectangle synchronously by calling updateMarkerRenderedRect in
DocumentMarkerController::addMarker.

This is not needed, since when we retrieve the rendered rectangles
(only possible via DMC::renderedRectsForMarkers),
updateMarkerRenderedRectIfNeed is also called, calculating the marker's
rendered rectangle if we haven't done it before.

Hence, this patch removes the updateMarkerRenderedRect call from
DMC::addMarker as a performance improvement.

BUG=668408
Committed: https://crrev.com/f6763007a1508ccbff5f635202c950367769855e
Cr-Commit-Position: refs/heads/master@{#436553}

[Xiaocheng, 2016-12-06 08:08:24]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 08:08:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-12-06 08:15:23]

Description was changed from

==========
Make calculation of document marker's rendered rect on demand

BUG=668408
==========

to

==========
Make calculation of document marker's rendered rect on demand

Currently, when adding a document marker, we calculate its rendered
rectangle synchronously by calling updateMarkerRenderedRect in
DocumentMarkerController::addMarker.

This is not needed, since when we retrieve the rendered rectangles
(only possible via DMC::renderedRectsForMarkers),
updateMarkerRenderedRectIfNeed is also called, calculating the marker's
rendered rectangle if we haven't done it before.

Hence, this patch removes the updateMarkerRenderedRect call from
DMC::addMarker as a performance improvement.

BUG=668408
==========

[Xiaocheng, 2016-12-06 08:20:29]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-12-06 08:20:30]

PTAL.

In fact, the only client of marker's rendered rectangles is scrollbar, who uses
them to paint the tick markers for each text match. I hope this patch is not
going to severely affect the performance of scrollbar painting...

[tkent, 2016-12-06 09:01:32]

lgtm

[Xiaocheng, 2016-12-06 09:04:11]

The CQ bit was unchecked by xiaochengh@chromium.org

[Xiaocheng, 2016-12-06 09:04:21]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-12-06 09:04:21]

Thanks for the review!

[commit-bot: I haz the power, 2016-12-06 09:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 09:30:12]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481015061239710, "parent_rev":
"cca2b235fb472ea9871157eec64ac98cffa7e5c2", "commit_rev":
"bdf90b0252f94646bec758a0bf37a0493451cb4c"}

[commit-bot: I haz the power, 2016-12-06 09:30:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 09:32:16]

Description was changed from

==========
Make calculation of document marker's rendered rect on demand

Currently, when adding a document marker, we calculate its rendered
rectangle synchronously by calling updateMarkerRenderedRect in
DocumentMarkerController::addMarker.

This is not needed, since when we retrieve the rendered rectangles
(only possible via DMC::renderedRectsForMarkers),
updateMarkerRenderedRectIfNeed is also called, calculating the marker's
rendered rectangle if we haven't done it before.

Hence, this patch removes the updateMarkerRenderedRect call from
DMC::addMarker as a performance improvement.

BUG=668408
==========

to

==========
Make calculation of document marker's rendered rect on demand

Currently, when adding a document marker, we calculate its rendered
rectangle synchronously by calling updateMarkerRenderedRect in
DocumentMarkerController::addMarker.

This is not needed, since when we retrieve the rendered rectangles
(only possible via DMC::renderedRectsForMarkers),
updateMarkerRenderedRectIfNeed is also called, calculating the marker's
rendered rectangle if we haven't done it before.

Hence, this patch removes the updateMarkerRenderedRect call from
DMC::addMarker as a performance improvement.

BUG=668408

Committed: https://crrev.com/f6763007a1508ccbff5f635202c950367769855e
Cr-Commit-Position: refs/heads/master@{#436553}
==========

[commit-bot: I haz the power, 2016-12-06 09:32:17]

Patchset 1 (id:??) landed as
https://crrev.com/f6763007a1508ccbff5f635202c950367769855e
Cr-Commit-Position: refs/heads/master@{#436553}