Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2367)

Unified Diff: appengine/findit/handlers/crash/crash_handler.py

Issue 2557553002: [Culprit-Finder] Seperate gae related part in cache_decorator and gitile repository to gae_libs/ (Closed)
Patch Set: Fix nits. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/gae_libs/test/caches_test.py ('k') | appengine/findit/handlers/help_triage.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/crash/crash_handler.py
diff --git a/appengine/findit/handlers/crash/crash_handler.py b/appengine/findit/handlers/crash/crash_handler.py
index 939a8b730dff08301eb5c364f8fefa8c7f30dae7..b7f7efb5640478cc59842d7cd21164efac9c62fc 100644
--- a/appengine/findit/handlers/crash/crash_handler.py
+++ b/appengine/findit/handlers/crash/crash_handler.py
@@ -13,7 +13,7 @@ from common.base_handler import Permission
from common.http_client_appengine import HttpClientAppengine
from crash import crash_pipeline
from crash.crash_report import CrashReport
-from lib.gitiles.gitiles_repository import GitilesRepository
+from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository
class CrashHandler(BaseHandler):
@@ -119,7 +119,7 @@ def ScheduleNewAnalysis(crash_data):
If we can detect that the analysis doesn't need to be performed
(e.g., it was already performed, or the ``crash_data`` is empty so
- there's nothig we can do), then we will skip creating the pipeline
+ there's nothing we can do), then we will skip creating the pipeline
at all.
Args:
@@ -129,7 +129,7 @@ def ScheduleNewAnalysis(crash_data):
True if we started a new pipeline; False otherwise.
"""
client_id = crash_data['client_id']
- repository = GitilesRepository(HttpClientAppengine())
+ repository = CachedGitilesRepository(HttpClientAppengine())
# N.B., must call FinditForClientID indirectly, for mock testing.
findit_client = crash_pipeline.FinditForClientID(client_id, repository)
« no previous file with comments | « appengine/findit/gae_libs/test/caches_test.py ('k') | appengine/findit/handlers/help_triage.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698