Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1804)

Unified Diff: appengine/findit/lib/gitiles/gitiles_repository.py

Issue 2557553002: [Culprit-Finder] Seperate gae related part in cache_decorator and gitile repository to gae_libs/ (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/lib/gitiles/gitiles_repository.py
diff --git a/appengine/findit/lib/gitiles/gitiles_repository.py b/appengine/findit/lib/gitiles/gitiles_repository.py
index 1dc4cb6e784c7128afe45f821859dd54980ecee1..109d1a6a0a067a5c1350f971910059cda19ffd3b 100644
--- a/appengine/findit/lib/gitiles/gitiles_repository.py
+++ b/appengine/findit/lib/gitiles/gitiles_repository.py
@@ -8,9 +8,6 @@ from datetime import timedelta
import json
import re
-# TODO(http://crbug.com/660466): We should try to break dependencies.
-from lib.cache_decorator import Cached
-from lib.cache_decorator import CompressedMemCacher
from lib.gitiles import commit_util
from lib.gitiles import diff
from lib.gitiles.blame import Blame
@@ -58,8 +55,6 @@ class GitilesRepository(GitRepository):
def identifier(self):
return self.repo_url
- @Cached(namespace='Gitiles-json-view', expire_time=CACHE_EXPIRE_TIME_SECONDS,
- cacher=CompressedMemCacher())
def _SendRequestForJsonResponse(self, url, params=None):
if params is None: # pragma: no cover
params = {}
@@ -76,7 +71,6 @@ class GitilesRepository(GitRepository):
return json.loads(content[len(prefix):])
- @Cached(namespace='Gitiles-text-view', expire_time=CACHE_EXPIRE_TIME_SECONDS)
def _SendRequestForTextResponse(self, url):
status_code, content = self.http_client.Get(url, {'format': 'text'})
if status_code != 200:

Powered by Google App Engine
This is Rietveld 408576698