Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngineTest.cpp

Issue 2557533005: Collect active stylesheets and and apply asynchronously. (Closed)
Patch Set: [Mac] Missing style recalc for device scale change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
diff --git a/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp b/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
index fcac598f633f1aace508d038e37520358419e042..d52a3c51e8562aff1ad86bb298d519c1481977aa 100644
--- a/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
+++ b/third_party/WebKit/Source/core/dom/StyleEngineTest.cpp
@@ -339,8 +339,7 @@ TEST_F(StyleEngineTest, StyleMediaAttributeStyleChange) {
document().view()->updateAllLifecyclePhases();
unsigned afterCount = styleEngine().styleForElementCount();
- // TODO(rune@opera.com): Should be 1u for ruleset based invalidations.
- EXPECT_EQ(8u, afterCount - beforeCount);
+ EXPECT_EQ(1u, afterCount - beforeCount);
ASSERT_TRUE(t1->computedStyle());
EXPECT_EQ(makeRGB(0, 128, 0),
@@ -366,8 +365,7 @@ TEST_F(StyleEngineTest, StyleMediaAttributeNoStyleChange) {
document().view()->updateAllLifecyclePhases();
unsigned afterCount = styleEngine().styleForElementCount();
- // TODO(rune@opera.com): Should be 0 for ruleset based invalidations.
- EXPECT_EQ(8u, afterCount - beforeCount);
+ EXPECT_EQ(0u, afterCount - beforeCount);
ASSERT_TRUE(t1->computedStyle());
EXPECT_EQ(makeRGB(0, 128, 0),

Powered by Google App Engine
This is Rietveld 408576698