chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 2557533003: [Mac] Fixed permission bubble position in fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2557533003: [Mac] Fixed permission bubble position in fullscreen (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index bf0c2526ee7b69e22d355075e0dd96eb0168487b..8de8b1a0db208bc80897f52e2d431d04ecb29cc1 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1977,7 +1977,10 @@ willAnimateFromState:(BookmarkBar::State)oldState

}

- (BOOL)hasToolbar {

- return [self supportsWindowFeature:Browser::FEATURE_TOOLBAR];

+ FullscreenToolbarLayout layout =

+ [[self fullscreenToolbarController] computeLayout];

+ return layout.toolbarStyle != FullscreenToolbarStyle::TOOLBAR_NONE &&

+ [self supportsWindowFeature:Browser::FEATURE_TOOLBAR];

}

- (BOOL)hasLocationBar {

« no previous file with comments | « no previous file | no next file » | no next file with comments »