Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2557533002: Update failing chrome tests after chrome 55 roll (issue #27991), also update a (Closed)

Created:
4 years ago by Siggi Cherem (dart-lang)
Modified:
4 years ago
Reviewers:
Bill Hesse, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update failing chrome tests after chrome 55 roll (issue #27991), also update a status comment. Committed: https://github.com/dart-lang/sdk/commit/0cb170488ce389ea162cc62b8699fe9b5a8b2167

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M tests/co19/co19-dart2js.status View 9 chunks +7 lines, -3 lines 0 comments Download
M tests/html/html.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
tbr
4 years ago (2016-12-05 22:35:00 UTC) #3
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as 0cb170488ce389ea162cc62b8699fe9b5a8b2167 (presubmit successful).
4 years ago (2016-12-05 22:38:10 UTC) #5
sra1
4 years ago (2016-12-05 23:03:53 UTC) #6
Message was sent while issue was closed.
LGTM.
Can you file a bug for the html issues and use that # in the comments?

Powered by Google App Engine
This is Rietveld 408576698