Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: media/audio/audio_input_controller.cc

Issue 255753003: Test code for issue 3 channels audio. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webrtc_audio_capturer.cc ('k') | media/audio/pulse/audio_manager_pulse.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_input_controller.cc
diff --git a/media/audio/audio_input_controller.cc b/media/audio/audio_input_controller.cc
index 490c62b3c16df6794d1ff6d17d18147f9c759a2c..b8582185f504ae2b92e4a8e990040af0e766a26f 100644
--- a/media/audio/audio_input_controller.cc
+++ b/media/audio/audio_input_controller.cc
@@ -114,8 +114,15 @@ scoped_refptr<AudioInputController> AudioInputController::CreateLowLatency(
DCHECK(audio_manager);
DCHECK(sync_writer);
- if (!params.IsValid() || (params.channels() > kMaxInputChannels))
+ if (!params.IsValid()) {
+ NOTREACHED();
return NULL;
+ }
+
+ if ((params.channels() > kMaxInputChannels)) {
+ NOTREACHED() << params.channels();
+ return NULL;
+ }
// Create the AudioInputController object and ensure that it runs on
// the audio-manager thread.
@@ -191,6 +198,7 @@ void AudioInputController::SetAutomaticGainControl(bool enabled) {
void AudioInputController::DoCreate(AudioManager* audio_manager,
const AudioParameters& params,
const std::string& device_id) {
+// NOTREACHED();
DCHECK(task_runner_->BelongsToCurrentThread());
SCOPED_UMA_HISTOGRAM_TIMER("Media.AudioInputController.CreateTime");
@@ -221,6 +229,7 @@ void AudioInputController::DoCreateForStream(
stream_ = stream_to_control;
if (!stream_) {
+ LOG(ERROR) << "***** NO VALID STREAM OBJECT";
if (handler_)
handler_->OnError(this, STREAM_CREATE_ERROR);
return;
@@ -229,6 +238,7 @@ void AudioInputController::DoCreateForStream(
if (stream_ && !stream_->Open()) {
stream_->Close();
stream_ = NULL;
+ LOG(ERROR) << "***** CAN't OPEN STREAM";
if (handler_)
handler_->OnError(this, STREAM_OPEN_ERROR);
return;
« no previous file with comments | « content/renderer/media/webrtc_audio_capturer.cc ('k') | media/audio/pulse/audio_manager_pulse.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698