Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/ntp/most_visited_sites_bridge.cc ('k') | components/ntp_tiles/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
index fcb0b593c80105251cb016d131d78c7d92d403a8..f67c8ccb24d249d25e79548d45f1e63fe4044f8e 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
@@ -155,9 +155,7 @@ void NTPUserDataLogger::EmitNtpStatistics(base::TimeDelta load_time) {
DVLOG(1) << "Emitting NTP load time: " << load_time << ", "
<< "number of tiles: " << impression_was_logged_.count();
- std::vector<std::pair<ntp_tiles::NTPTileSource,
- ntp_tiles::metrics::MostVisitedTileType>>
- tiles;
+ std::vector<ntp_tiles::metrics::TileImpression> tiles;
bool has_server_side_suggestions = false;
for (int i = 0; i < kNumMostVisited; i++) {
if (!impression_was_logged_[i]) {
@@ -167,10 +165,14 @@ void NTPUserDataLogger::EmitNtpStatistics(base::TimeDelta load_time) {
ntp_tiles::NTPTileSource::SUGGESTIONS_SERVICE) {
has_server_side_suggestions = true;
}
+ // No URL passed since we're not interested in favicon-related Rappor
+ // metrics.
tiles.emplace_back(impression_tile_source_[i],
- ntp_tiles::metrics::THUMBNAIL);
+ ntp_tiles::metrics::THUMBNAIL, GURL());
}
- ntp_tiles::metrics::RecordPageImpression(tiles);
+
+ // Not interested in Rappor metrics.
+ ntp_tiles::metrics::RecordPageImpression(tiles, /*rappor_service=*/nullptr);
LogLoadTimeHistogram("NewTabPage.LoadTime", load_time);
« no previous file with comments | « chrome/browser/android/ntp/most_visited_sites_bridge.cc ('k') | components/ntp_tiles/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698