Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: components/ntp_tiles/BUILD.gn

Issue 2557513007: ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type. (Closed)
Patch Set: Addressed comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_tiles/BUILD.gn
diff --git a/components/ntp_tiles/BUILD.gn b/components/ntp_tiles/BUILD.gn
index 503c3866c3d6217a853e52d480bf5e47df487a1d..1805a4ddd59d27dc7b50b8b8ad290585c0517af0 100644
--- a/components/ntp_tiles/BUILD.gn
+++ b/components/ntp_tiles/BUILD.gn
@@ -46,6 +46,7 @@ static_library("ntp_tiles") {
"//components/image_fetcher",
"//components/pref_registry",
"//components/prefs",
+ "//components/rappor/public",
"//components/search_engines",
"//components/url_formatter",
"//components/variations",
@@ -77,6 +78,7 @@ source_set("unit_tests") {
testonly = true
sources = [
"icon_cacher_unittest.cc",
+ "metrics_unittest.cc",
"most_visited_sites_unittest.cc",
"popular_sites_unittest.cc",
]
@@ -89,6 +91,7 @@ source_set("unit_tests") {
"//components/favicon_base",
"//components/image_fetcher",
"//components/pref_registry:test_support",
+ "//components/rappor:test_support",
"//net:test_support",
"//testing/gmock",
"//testing/gtest",

Powered by Google App Engine
This is Rietveld 408576698