ntp_tiles::metrics: Add rappor metrics for impression URLs per icon type.

chrome/browser/android/ntp/most_visited_sites_bridge.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/ntp/most_visited_sites_bridge.h"
 
 #include <utility>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 13 matching lines @@
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/supervised_user/supervised_user_service.h"
 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
 #include "chrome/browser/supervised_user/supervised_user_url_filter.h"
 #include "chrome/browser/thumbnails/thumbnail_list_source.h"
 #include "components/history/core/browser/top_sites.h"
 #include "components/image_fetcher/image_fetcher_impl.h"
 #include "components/ntp_tiles/icon_cacher.h"
 #include "components/ntp_tiles/metrics.h"
 #include "components/ntp_tiles/popular_sites.h"
+#include "components/rappor/rappor_service_impl.h"
 #include "components/safe_json/safe_json_parser.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/url_data_source.h"
 #include "jni/MostVisitedSites_jni.h"
 #include "ui/gfx/android/java_bitmap.h"
 #include "url/gurl.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertJavaStringToUTF8;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::JavaParamRef;
 using base::android::ScopedJavaGlobalRef;
 using base::android::ScopedJavaLocalRef;
 using base::android::ToJavaArrayOfStrings;
 using base::android::ToJavaIntArray;
 using content::BrowserThread;
 using ntp_tiles::metrics::MostVisitedTileType;
+using ntp_tiles::metrics::TileImpression;
 using ntp_tiles::MostVisitedSites;
 using ntp_tiles::MostVisitedSitesSupervisor;
 using ntp_tiles::NTPTileSource;
 using suggestions::SuggestionsServiceFactory;
 
 MostVisitedSitesBridge::SupervisorBridge::SupervisorBridge(Profile* profile)
     : profile_(profile),
       supervisor_observer_(nullptr),
       register_observer_(this) {
   register_observer_.Add(SupervisedUserServiceFactory::GetForProfile(profile_));
@@ skipping 135 matching lines @@
     const JavaParamRef<jstring>& j_url,
     jboolean add_url) {
   GURL url(ConvertJavaStringToUTF8(env, j_url));
   most_visited_.AddOrRemoveBlacklistedUrl(url, add_url);
 }
 
 void MostVisitedSitesBridge::RecordPageImpression(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj,
     const JavaParamRef<jintArray>& jtile_types,
-    const JavaParamRef<jintArray>& jsources) {
+    const JavaParamRef<jintArray>& jsources,
+    const JavaParamRef<jobjectArray>& jtile_urls) {
   std::vector<int> int_sources;
   base::android::JavaIntArrayToIntVector(env, jsources, &int_sources);
   std::vector<int> int_tile_types;
   base::android::JavaIntArrayToIntVector(env, jtile_types, &int_tile_types);
+  std::vector<std::string> string_tile_urls;
+  base::android::AppendJavaStringArrayToStringVector(env, jtile_urls,
+                                                     &string_tile_urls);
 
   DCHECK_EQ(int_sources.size(), int_tile_types.size());
+  DCHECK_EQ(int_sources.size(), string_tile_urls.size());
 
-  std::vector<std::pair<NTPTileSource, MostVisitedTileType>> tiles;
+  std::vector<TileImpression> tiles;
   for (size_t i = 0; i < int_sources.size(); i++) {
     NTPTileSource source = static_cast<NTPTileSource>(int_sources[i]);
     MostVisitedTileType tile_type =
         static_cast<MostVisitedTileType>(int_tile_types[i]);
-    tiles.emplace_back(source, tile_type);
+
+    tiles.emplace_back(source, tile_type, GURL(string_tile_urls[i]));
   }
-  ntp_tiles::metrics::RecordPageImpression(tiles);
+  ntp_tiles::metrics::RecordPageImpression(tiles,
+                                           g_browser_process->rappor_service());
 }
 
 void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj,
     jint index,
     jint tile_type,
     jint source) {
   ntp_tiles::metrics::RecordTileClick(
       index, static_cast<NTPTileSource>(source),
       static_cast<MostVisitedTileType>(tile_type));
 }
 
 // static
 bool MostVisitedSitesBridge::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 static jlong Init(JNIEnv* env,
                   const JavaParamRef<jobject>& obj,
                   const JavaParamRef<jobject>& jprofile) {
   MostVisitedSitesBridge* most_visited_sites =
       new MostVisitedSitesBridge(
           ProfileAndroid::FromProfileAndroid(jprofile));
   return reinterpret_cast<intptr_t>(most_visited_sites);
 }